Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a month separator feature (#14) #17

Closed
wants to merge 2 commits into from

Conversation

ma-schmidt
Copy link
Contributor

To draw the lines, I had to modify some part of the code:

  1. Added a "month" column to the dataframe.
  2. If the first days of the year are part of last year's week (would be week 52), offset every week by 1 so they are now week 1, the previous week 1 is now week 2, etc. This is so that we know where to draw the lines.
  3. I have added a small padding to the axes (0.3 of one cell) in order to avoid the outside lines being cut by the axes limit.
  4. The month ticks position has been slightly pushed to the left so that their center now lines up with the center of the average week number.

This PR will break the tests because the output images are going to be different. This is not due to the month separator per se but to the slight esthetic changes (more margin and tick labels more centered). Would need to regenerate the baseline images.

@MarvinT
Copy link

MarvinT commented Nov 23, 2018

I've taken over maintaining this package, please submit a PR to my dev branch: https://github.com/MarvinT/calmap/tree/dev
Thanks!

@MarvinT
Copy link

MarvinT commented Jul 10, 2021

Hi, if this problem still exists and you'd like to create a PR to fix it please direct it to https://github.com/MarvinT/calmap/
That is the version that gets published to pypi and has received several updates to fix some existing issues.

@martijnvermaat
Copy link
Owner

Thank you for your contribution. Unfortunately I don't have the time to maintain this project. As per @MarvinT 's comment, please see https://github.com/MarvinT/calmap/ instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants