Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with the 'sum' aggregation. #27

Closed
yygrechka opened this issue Feb 4, 2019 · 3 comments
Closed

Bug with the 'sum' aggregation. #27

yygrechka opened this issue Feb 4, 2019 · 3 comments

Comments

@yygrechka
Copy link

yygrechka commented Feb 4, 2019

When I run the code on the doc page:
import numpy as np; np.random.seed(sum(map(ord, 'calmap')))
import pandas as pd
import calmap

all_days = pd.date_range('1/15/2014', periods=700, freq='D')
days = np.random.choice(all_days, 500)
events = pd.Series(np.random.randn(len(days)), index=days)
calmap.yearplot(events, year=2015)
I get the following result:
screenshot1
Only when I change the aggregation to be mean, I get the expected result:

calmap.yearplot(events, year=2015,how=u'mean')
screenshot from 2019-02-03 22-36-33

python version: 3.7.1
pandas version: 0.23.4
calmap version: 0.0.7
matplotlib version: 3.0.1

@tomkwok
Copy link

tomkwok commented Jan 14, 2020

This is fixed with the addition of a dropzero argument with a default True value for calplot in calplot.

@MarvinT
Copy link

MarvinT commented Jul 10, 2021

Hi, if this problem still exists and you'd like to create a PR to fix it please direct it to https://github.com/MarvinT/calmap/
That is the version that gets published to pypi and has received several updates to fix some existing issues.

@martijnvermaat
Copy link
Owner

Thank you for creating the issue. Unfortunately I don't have the time to maintain this project. As per @MarvinT 's comment, please see https://github.com/MarvinT/calmap/ instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants