Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing start script - Update Readme #325

Closed
heikoter opened this issue May 24, 2021 · 1 comment · Fixed by #382
Closed

Missing start script - Update Readme #325

heikoter opened this issue May 24, 2021 · 1 comment · Fixed by #382
Projects
ChordFiddle

Comments

@heikoter
Copy link

Am I wrong or does something wrong?
But if I follow the instructions in readme yarn start script is missing in package.json

btw: really great project! Looking forward to support you
@martijnversluis
Copy link
Owner

martijnversluis commented Aug 13, 2021 •
edited
Loading

Hey @heikoter

I’m very sorry to have missed your question, for some reason I did not receive a notification.

You’re not wrong, the README is. With the 2.0 release I changed the app from React to a vanilla JS version, but I did not update the docs.

I’ll try my best to fix the docs and maybe add a development server if necessary.

@martijnversluis martijnversluis added this to To Do in ChordFiddle via automation Aug 13, 2021
martijnversluis added a commit that referenced this issue Aug 17, 2021
@martijnversluis
Re-add yarn start
4acb40e 
`yarn start` will launch a Webpack dev server and open the default browser.

Resolves #325
@martijnversluis martijnversluis mentioned this issue Aug 17, 2021
Merged
martijnversluis added a commit that referenced this issue Aug 17, 2021
@martijnversluis
Re-add yarn start
4057da3 
`yarn start` will launch a Webpack dev server and open the default browser.

Resolves #325
martijnversluis added a commit that referenced this issue Aug 17, 2021
@martijnversluis
Re-add yarn start
60cde22 
`yarn start` will launch a Webpack dev server and open the default browser.

Resolves #325
ChordFiddle automation moved this from To Do to Done Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
ChordFiddle
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-add yarn start martijnversluis/ChordFiddle
2 participants
@martijnversluis @heikoter