-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erro 'null' #1163
Comments
Hey @gpr19. Thanks for reaching out! Could you elaborate on the code that is used to render the sheet? It would be nice to have the minimal bit of code that breaks on 9.0.1 or returns a different result. |
I'm experiencing this issue, for example, with this setup:
const sheet = ` F Am Dm Gm C
Tonight I’m gonna have myself a real good time, I feel alive
F F7 Bb Gm7 D7
And the world, I'll turn it inside out yeah, I'm floating around in ecstasy
Gm F C Gm Gm F C
So don’t stop me now, don’t stop me
Gm F/G Gm7 C Dm7/C C7
Cause I’m having a good time, having a good time
`; The last empty line will produce a null being displayed, as you can see in this image: This could be fixed by the client that is using the ChordSheetJS library by just trimming the sheet, but it would be great if the library could handle this scenario by itself. |
The same happens when two or more line breaks appear together in the middle of the sheet. Here is the fix that I'm using before calling the ChordsOverWordsParser class:
Does it make sense to include the fix in the ChordsOverWordsParser parser method? |
@gpr19 I think if found the issue, and I merged a fix. Will try to publish it soon 👍 |
I'm having an error in this new version, before I was using 9.0.0. This week I started a new project to test with the latest version (9.0.1).
When the enter key shows 'null'
Version 9.0.1:
![image](https://private-user-images.githubusercontent.com/98890138/328275656-5d53b821-af77-4427-bae3-82bed68af27c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNjUzNzcsIm5iZiI6MTcyMTI2NTA3NywicGF0aCI6Ii85ODg5MDEzOC8zMjgyNzU2NTYtNWQ1M2I4MjEtYWY3Ny00NDI3LWJhZTMtODJiZWQ2OGFmMjdjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDAxMTExN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY4MGFjYzQzNzhlMjFhZmYzOGZmZGVhM2M1OTczNTVjMWFiZjU0M2VjZmM1MGFkMDEyYjk2ZDM4MzIyMTVkZTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.OeMBKbOKNytsS97w4XLPYChGerLx2oMHDTOSlI3gYVI)
But in version 9.0.0 works fine:
![image](https://private-user-images.githubusercontent.com/98890138/328276001-cd226f19-9c59-47a8-8b6b-f23e5e579c54.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNjUzNzcsIm5iZiI6MTcyMTI2NTA3NywicGF0aCI6Ii85ODg5MDEzOC8zMjgyNzYwMDEtY2QyMjZmMTktOWM1OS00N2E4LThiNmItZjIzZTVlNTc5YzU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDAxMTExN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThkNmQ1YTczMzU5NDk5OWI1NmQ2ODZjNmQ0M2E0MmRlNGNhZDQwM2FhODgwNWQ2ZTkzN2Y3NTVlNGY0MzUyN2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.F51bILJTeHs7JnC_MBMR4nQWXGRsQWKIKrRQECEP180)
The text was updated successfully, but these errors were encountered: