Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we ONLY create icons? #27

Open
AlixH opened this issue Oct 26, 2023 · 7 comments
Open

Can we ONLY create icons? #27

AlixH opened this issue Oct 26, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@AlixH
Copy link

AlixH commented Oct 26, 2023

I would like to only create the icons without modifying any file, including the AndroidManifest.xml

@martiliones martiliones self-assigned this Oct 26, 2023
@martiliones martiliones added the question Further information is requested label Oct 26, 2023
@martiliones
Copy link
Owner

Hello. I don't think we have such an option, but we can implement it.

What exact functionality are you looking for? Please tell me more. Do you want to generate icons inside specific directory without overwriting ic_launcher? or do you still want to create the icons inside android/ios directories without overwriting manifest files?

@martiliones martiliones added the enhancement New feature or request label Oct 26, 2023
@martiliones
Copy link
Owner

Thanks for your contributing. I just merged #26 and published a new version (icon-set-creator@1.2.6) with additional Android support. Let me know if this solves your issue.

@AlixH
Copy link
Author

AlixH commented Oct 26, 2023

Thank you so much for quick feedback !
Ideally I would like to be able to generate icons inside a custom directory AND not modify any other existing files. So neither AndroidManifest.xml, nor colors.xml
I think manifest file update can be done manually when option enabled, and colors.xml can be renamed colors-launcher.xml , or just colors.xml inside the custom dir

@martiliones
Copy link
Owner

What about this: I will create "custom directory" option that will generate the icons with all the files in the same structure it would in the project (e.g. customDirectory/android/app/src/main/) and you will be able to combine it with disableLaunchIcon to generate only icons without the structure

@AlixH
Copy link
Author

AlixH commented Oct 26, 2023

What about this: I will create "custom directory" option that will generate the icons with all the files in the same structure it would in the project (e.g. customDirectory/android/app/src/main/) and you will be able to combine it with disableLaunchIcon to generate only icons without the structure

What do you mean by "without the structure" ?
I will give an example of what I have in mind :
iconset --outputDir android/app/src/main/iconsetRes
This would generate all asset folders and colors files inside the custom directory relative to the dir where you run the command.

And the command disableLaunchIcon would additionally leave existing files untouched. But I think it would be easier to always leave them untouched when the custom dir option is used because otherwise you will have to add the custom dirs inside the manifest and build.gradle to link the generated colors and assets

@martiliones
Copy link
Owner

This what I had in my head:

When you try to generate icons in custom directory without --disable-launcher-icon flag, it would create icons with the entire android/ios directories structure and manifest files examples:

$ iconset --output customDir/

customDir
├── android
│   └── app
│       └── src
│           └── main
│               └── res
└── ios
    ├── project
    │   └── Images.xcassets
    └── project.xcodeproj

This way you could just drag&drop content of the customDir into your project.

When using with --disable-launcher-icon:

$ iconset -disable-launcher-icon --output customDir/

customDir
├── android
│   ├── myicon.png
│   └── myicon_round.png
└── ios
    └── myicon-29x29@2x.png

@AlixH
Copy link
Author

AlixH commented Oct 26, 2023

This what I had in my head:

When you try to generate icons in custom directory without --disable-launcher-icon flag, it would create icons with the entire android/ios directories structure and manifest files examples:

$ iconset --output customDir/

customDir
├── android
│   └── app
│       └── src
│           └── main
│               └── res
└── ios
    ├── project
    │   └── Images.xcassets
    └── project.xcodeproj

This way you could just drag&drop content of the customDir into your project.

When using with --disable-launcher-icon:

$ iconset -disable-launcher-icon --output customDir/

customDir
├── android
│   ├── myicon.png
│   └── myicon_round.png
└── ios
    └── myicon-29x29@2x.png

Well, my scenario is: I have a RN project with no assets. I need to be able to generate all assets dynamically inside a custom directory inside both android and ios directories. By one command I could change the app assets and build it with new icons without needing to copy paste anything and without impacting my git working tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants