Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid atom ordering in Impact template #108

Closed
martimunicoy opened this issue Nov 25, 2020 · 1 comment · Fixed by #107 or #99
Closed

Invalid atom ordering in Impact template #108

martimunicoy opened this issue Nov 25, 2020 · 1 comment · Fixed by #107 or #99
Labels
bug Something isn't working
Projects

Comments

@martimunicoy
Copy link
Owner

Description

We detected extremely large computational times in the Side Chain Prediction algorithm when using Impact templates generated with peleffy. The reason of this undesired behaviour seems to be a consequence of a bad atom ordering in these templates. Atoms are not properly sorted by their parent indices.

Solution

Fix the ordering in the Impact template.

@martimunicoy martimunicoy added the bug Something isn't working label Nov 25, 2020
@martimunicoy martimunicoy added this to To do in 1.1.0 via automation Nov 25, 2020
@martimunicoy martimunicoy linked a pull request Nov 25, 2020 that will close this issue
5 tasks
@martimunicoy
Copy link
Owner Author

Extended description

Now we know that the atoms in the Impact template need to be sorted by two criteria:

  • Atom location: first atoms from the core, then atoms from the side chain
  • Parent index: ascending order of parent indices according to the molecular graph

The problem was that, although atoms where correctly sorted by atom location, they were not following the right criteria with parent indices. As a result, PELE was able to load molecular topologies with no problem but, in some cases, this bad ordering lead to problems when running the side chain prediction algorithm. In these cases, side chain prediction algorithm could require a large computational time (e.g more than 1000s).

This issue seems fixed with the correct order of the atoms in the Impact template file.

@martimunicoy martimunicoy linked a pull request Dec 1, 2020 that will close this issue
5 tasks
1.1.0 automation moved this from To do to Done Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
1.1.0
Done
Development

Successfully merging a pull request may close this issue.

1 participant