Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load parameters from JSON #130

Closed
laumalo opened this issue Feb 9, 2021 · 0 comments · Fixed by #131
Closed

Load parameters from JSON #130

laumalo opened this issue Feb 9, 2021 · 0 comments · Fixed by #131
Assignees
@laumalo
Labels
enhancement New feature or request

Comments

@laumalo
Copy link
Collaborator

laumalo commented Feb 9, 2021

Description

Currently we have implemented a method to_json for the BaseParameterWrapper to save the parameters into a JSON file, a matching from_json method to load the parameters from this file should also be implemented.

Solution

Implement an instance method in the BaseParameterWrapper class to load the parameters from a JSON file.
@laumalo laumalo added the enhancement New feature or request label Feb 9, 2021
@laumalo laumalo self-assigned this Feb 9, 2021
@laumalo laumalo linked a pull request Feb 9, 2021 that will close this issue
Load parameters from JSON file #131
Merged
5 tasks
@laumalo laumalo closed this as completed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laumalo laumalo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load parameters from JSON file martimunicoy/peleffy
1 participant
@laumalo