Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecule from SMILES is unnamed #41

Closed
martimunicoy opened this issue Sep 2, 2020 · 1 comment · Fixed by #46 or #43
Closed

Molecule from SMILES is unnamed #41

martimunicoy opened this issue Sep 2, 2020 · 1 comment · Fixed by #46 or #43
Labels
invalid This doesn't seem right
Projects

Comments

@martimunicoy
Copy link
Owner

Description

When an offpele Molecule is initialized from a SMILES tag, no name is set to it. This behavior can cause some problems later when generating the template files.

Solution

We should assign a default name in Molecule objects.

@martimunicoy martimunicoy added bug Something isn't working invalid This doesn't seem right and removed bug Something isn't working labels Sep 2, 2020
@martimunicoy martimunicoy added this to To do in 0.3.0 via automation Sep 2, 2020
@martimunicoy
Copy link
Owner Author

Solution 2

A new parameter for Molecule called name could help. In this way, the user could always choose a custom name for the molecule. When this parameter is not given, then, the name could be retrieved from the PDB file (like we are currently doing). Otherwise, a default name like UNL should be set.

This was linked to pull requests Sep 3, 2020
0.3.0 automation moved this from To do to Done Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
No open projects
0.3.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant