Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments about vignette #27

Open
5 tasks
HeidiSeibold opened this issue Apr 15, 2019 · 0 comments
Open
5 tasks

Comments about vignette #27

HeidiSeibold opened this issue Apr 15, 2019 · 0 comments

Comments

@HeidiSeibold
Copy link
Collaborator

HeidiSeibold commented Apr 15, 2019

@mmostly-harmless you asked me to take a look at the vignette. Here are my comments. None of these are crucial. So don't feel obliged to incorporate them. All in all I like the vignette 馃巻 .

  • I am wondering if it would be easier to start with a ctree()-example rather than one where you create the tree yourself.

https://github.com/mmostly-harmless/ggparty/blob/83539bd0a98b2a5f8c20b1feffae935945e34a0a/vignettes/ggparty-graphic-partying.Rmd#L138-L150

  • One of the comments below shows after the plot. Could be nicer. Maybe write it in text rather than in comment?

https://github.com/mmostly-harmless/ggparty/blob/83539bd0a98b2a5f8c20b1feffae935945e34a0a/vignettes/ggparty-graphic-partying.Rmd#L208-L214

  • Section Additional Data does seem quite advanced for this early in the vignette. I would first show a couple of simple examples. Maybe even have a separate vignette for this?

  • When are predictions possible?

https://github.com/mmostly-harmless/ggparty/blob/83539bd0a98b2a5f8c20b1feffae935945e34a0a/vignettes/ggparty-graphic-partying.Rmd#L437-L439

  • Maybe show the Autoplot Methods earlier in the vignette?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant