Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GETs and leases #9

Closed
kberzinch opened this issue Jul 19, 2020 · 3 comments
Closed

Add support for GETs and leases #9

kberzinch opened this issue Jul 19, 2020 · 3 comments

Comments

@kberzinch
Copy link

This is super helpful, thank you for publishing it.

I do have two small requests. For some context, I'm using this with a small on-prem Concourse to authenticate to a GitHub Enterprise instance to pull code. Concourse officially only supports kv v1 for Vault, but with a little bit of fiddling it will talk to any secrets engine with some caveats:

  • For retrieving credentials, it will only use GET. This plugin does not support GET for retrieving tokens.

  • If credential caching is enabled, it will respect Vault lease durations if returned. If credential caching is NOT enabled, it will pull new credentials from vault every time they are used. This plugin does not return leases and so credential caching does not work properly even if the first one is hacked around (i.e. at the nginx level).

I wrote a small app that proxies requests from Concourse to this plugin to solve both of those issues, but if would be nice if they were supported directly.

I am not very familiar with Go (or Vault for that matter) so I would not be able to contribute these changes any time soon.

@martinbaillie
Copy link
Owner

Hi @kberzinch thanks for your interest. I did a bit of housecleaning on this project today and have hopefully catered for both of your requests in v1.0.0. Please give it a whirl if you're still using the plugin.

@martinbaillie
Copy link
Owner

Resolved with eea723c and 11b880b.

@kberzinch
Copy link
Author

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants