Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate header deps in gcc depfiles #423

Closed
evmar opened this issue Sep 17, 2012 · 3 comments
Closed

Duplicate header deps in gcc depfiles #423

evmar opened this issue Sep 17, 2012 · 3 comments
Labels

Comments

@evmar
Copy link
Collaborator

evmar commented Sep 17, 2012

I noticed multiple instances of the same header in a local depfile. I haven't yet tracked down why this occurs. See also #418.

@Lekensteyn
Copy link
Contributor

This occurs whenever the deps command generates duplicate dependencies. Can we just require non-duplicate entries from the command for simplicity?

build.ninja

rule gen
  command = echo "$out: x.h x.h" > $out.d && touch $out
  deps = gcc
  depfile = $out.d
build x: gen

Output of ninja -t deps

x: #deps 2, deps mtime 1508637043 (VALID)
    x.h
    x.h

@mathstuf
Copy link
Contributor

Couldn't the input list be deduped when reading as well (with a warning available for it possibly?). Though I think the logic pending #1534 seems to dedupe anyways. I now get this:

x: #deps 1, deps mtime 1580311346270505630 (VALID)
    x.h

@mathstuf
Copy link
Contributor

@jhasse Seems like this can be closed as well.

@jhasse jhasse closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants