Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using undefined value in Subprocess::OnPipeReady() #214

Merged
merged 1 commit into from Feb 4, 2012

Conversation

qhuo
Copy link
Contributor

@qhuo qhuo commented Feb 4, 2012

No description provided.

@qhuo
Copy link
Contributor Author

qhuo commented Feb 4, 2012

This is meant to fix #206.

@evmar
Copy link
Collaborator

evmar commented Feb 4, 2012

It's too bad they don't just define *bytes=0 for the ConnectNamedPipe case. Thanks for the patch!

evmar added a commit that referenced this pull request Feb 4, 2012
Avoid using undefined value in Subprocess::OnPipeReady()
@evmar evmar merged commit ff1c488 into ninja-build:master Feb 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants