Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an environment variable to set the default number of jobs used in parallel #816

Closed
wants to merge 1 commit into from

Conversation

glehmann
Copy link

No description provided.

to control the default number of parallel jobs. When not used, the default
number of jobs is still guessed from the number of processors
@buildhive
Copy link

Evan Martin » ninja #881 SUCCESS
This pull request looks good
(what's this?)

@evmar
Copy link
Collaborator

evmar commented Nov 11, 2015

A general way to handle this and some other similar requests might be to add a NINJA_DEFAULT_FLAGS env var that is interpreted as command line flags. But we'd then probably need some way to undo those values (e.g. a way to opt back in to the default -j behavior when there was a -j set in the environment).

@evmar
Copy link
Collaborator

evmar commented Nov 12, 2015

I think even if we want this feature (some way to control -j, see the bug), we won't want this implementation of it. So I'm closing this and leaving the bug open.

@evmar evmar closed this Nov 12, 2015
nicolasdespres added a commit to nicolasdespres/ninja that referenced this pull request Dec 20, 2015
When ninja invokes ninja (for instance when building a sub-project) it
is useful to have a way to control the flags used by the sub-ninja
process. If I pass '-d explain' or '-v' when starting
ninja from the command line on the top project, I expect these flags
to be forwarded to the sub-ninja process.

Note that this patch has limited parsing capabilities of the
NINJA_FLAGS environment variables but that should be enough for our
use case.

Fixes ninja-build#797, ninja-build#922 and ninja-build#816.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants