Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Clicking on the clock fails when changing input method #923

Closed
5 tasks done
Rewerson opened this issue Sep 14, 2022 · 27 comments
Closed
5 tasks done

[BUG/ISSUE] Clicking on the clock fails when changing input method #923

Rewerson opened this issue Sep 14, 2022 · 27 comments
Assignees
Labels
bug Something isn't working hard-one Idk if it is going to be possible to do that needs-further-study Needs further study

Comments

@Rewerson
Copy link

Before submitting the issue

  • I have checked that the bug is not a duplicate or, if it is, it needs to be reopened
  • I have checked that this issue is not present in the Known Issues section on the wiki.
  • I have checked that I am running the latest version of ElevenClock
  • I have tried resetting and reinstalling ElevenClock and the issue persisted or happened again
  • I have checked the Common Problems section on the wiki for solutions

Describe the bug

After reboot or logoff/login clicking on the clock has no effect as setted in options (neither default action of showing calendar popup, nor any other option). Doubleclick behaves the same way, if activate it too.

To Reproduce

Steps to reproduce the behaviour:

  1. Reboot
  2. Clock autostarts
  3. Click on the clock
  4. Nothing happens, only date tooltip oh hover is shown

Expected behaviour

Calendar popup appears

The Log

It took 0.0 to load all language files
---------------------------------------------------------------------------------------------------

   ElevenClock's 3.8.1 (v3.81) log: Select all the text and hit Ctrl+C to copy it
   All modules loaded successfully and sys.stdout patched correctly, starting main script
   Translator function set language to "ru"

---------------------------------------------------------------------------------------------------

 Log legend:
 🔵: Verbose
 🟢: Information
 🟡: Warning
 🟠: Handled unexpected exception
 🔴: Unhandled unexpected exception
 🟣: Handled expected exception

🔵 Initializing clock 0...
🔵 Using taskbar background color
🟢 Regular sized taskbar
🟢 Clock on the bottom
🟢 Clock on the right
🟢 Using qt's default positioning system
🔵 Clock geometry: PySide6.QtCore.QRect(1848, 1106, 200, 46)
🔵 Font families   : ['Segoe UI Variable Display', 'sans-serif']
🔵 Custom font     : 
🔵 Font size: -1.0
🟢 Using white text (dark mode)
🔵 tDateMode: dd.MM.yyyy
🔵 tTimeMode: HH:mm
🔵 Loaded date time format: %H:%M:%S 
%d.%m.%Y
🔵 Full screen rect:  (0, 0, 2048, 1152)
can't parse ""
🔵 Show/hide loop started with parameters: HideonFS:True, NotHideOnTB:False, HideOnRDP:False, ClockOn1Mon:True, NefWSMethod:True, DisableNotifications:True, legacyFullScreenMethod:False
🟡 Desktop button enabled
🟢 Loaded clocks in 0.2109966278076172
🔵 Restart loop: 1
{'System language': 'default', 'Arabic - عربي\u200e (66%)': 'ar', 'Bulgarian - български (19%)': 'bg', 'Catalan - Català': 'ca', 'Czech - Čeština': 'cs', 'Danish - Dansk (25%)': 'da', 'German - Deutsch (98%)': 'de', 'Greek - Ελληνικά (20%)': 'el', 'English - English': 'en', 'Spanish - Español (98%)': 'es', 'Estonian - eesti (98%)': 'et', 'Persian - فارسی\u200e (5%)': 'fa', 'Finnish - Suomi (67%)': 'fi', 'French - Français (98%)': 'fr', 'Hebrew - עִבְרִית\u200e (98%)': 'he', 'Hungarian - Magyar (98%)': 'hu', 'Indonesian - Bahasa Indonesia (98%)': 'id', 'Italian - Italiano (51%)': 'it', 'Japanese - 日本語 (98%)': 'ja', 'Korean - 한국어': 'ko', 'Lithuanian - Lietuvių (24%)': 'lt', 'Latvian - Latviski (65%)': 'lv', 'Norwegian (bokmål) (98%)': 'nb', 'Dutch - Nederlands (86%)': 'nl', 'Norwegian (nynorsk) (72%)': 'nn', 'Polish - Polski (98%)': 'pl', 'Portuguese (Brazil) (84%)': 'pt_BR', 'Portuguese (Portugal) (98%)': 'pt_PT', 'Romanian - Română (98%)': 'ro', 'Russian - Русский (98%)': 'ru', 'Sinhala - සිංහල': 'si', 'Slovak - Slovenčina (32%)': 'sk', 'Serbian - Srpski (24%)': 'sr', 'Swedish - Svenska (79%)': 'sv', 'Thai - ภาษาไทย (85%)': 'th', 'Turkish - Türkçe (21%)': 'tr', 'Ukranian - Yкраї́нська (26%)': 'ua', 'Vietnamese - Tiếng Việt (41%)': 'vi', 'Simplified Chinese (China) (98%)': 'zh_CN', 'Traditional Chinese (Taiwan) (98%)': 'zh_TW'}
🟢 Cached text input host hwnd: 131778
🟣 Expected AttributeError on checkAndUpdateBackground
🔵 System tray icon enabled
🔵 Starting update check
🔵 Low cpu mode is set to False. DisableNotifications is set to False
🟢 Loaded everything in 1.292356252670288
🔵 Version URL: https://versions.somepythonthings.tk/versions/elevenclock.ver
🟢 Updates not found
🔵 (worldtimeapi.org) Time offset set to 0.29222822189331055
🔵 Showing tooltip
🔵 Long date string: dddd, d MMMM yyyy 'г'.
🔵 Showing tooltip
🔵 Long date string: dddd, d MMMM yyyy 'г'.
🔵 Starting update check
🔵 Version URL: https://versions.somepythonthings.tk/versions/elevenclock.ver
🟢 Updates not found
🔵 Showing tooltip
🔵 Long date string: dddd, d MMMM yyyy 'г'.
🔵 Announcement URL: https://www.somepythonthings.tk/resources/elevenclock.announcement
🔵 Image URL: https://upload.wikimedia.org/wikipedia/commons/d/db/Google_Translate_Icon.png
🔵 Copying log to the clipboard...

Additional context

As I noticed, immediate clock restart is useless. But everything works if I start clock after some time of using PC, maybe after receiving some Windows notifications and clicking on standard Windows clock to see them, unfortunately didn't find out what exactly makes it work, just my observation.

@Rewerson Rewerson added bug Something isn't working triage This hasn't been chcked yet by any maintainer labels Sep 14, 2022
@marticliment
Copy link
Owner

Hi,

Could you please change the prefs again and then send the log again without restarting/reloading?

Thanks!

@marticliment marticliment added needs-author-answer Waiting for the author to answer. If author does not answer in 2 days, Issue gets closed and removed triage This hasn't been chcked yet by any maintainer labels Sep 14, 2022
@Rewerson
Copy link
Author

Changed some settings.
log.txt

@marticliment
Copy link
Owner

Fixed!

@Rewerson
Copy link
Author

Rewerson commented Sep 17, 2022

@martinet101
Unfortunately, problem exists in 3.8.2 too.
But there is difference in behaviour. When selected one of these actions on click: Open task manager, Open start menu, Change task - they work.
Don't work those, which are binded to Win+<letter>. But in system all of those shortcuts work normally, when pressing manually.

@marticliment
Copy link
Owner

marticliment commented Sep 17, 2022

This is weird... that worked for me.

However, this is a different issue than the old one.

Could you please

  1. Launch elevenClock
  2. Change the prefs, test some options (do not restart/quit ElevenClock)
  3. Send the log without quitting/restarting elevenClock.

@marticliment marticliment reopened this Sep 17, 2022
@Rewerson
Copy link
Author

Before launch there was set click action 'Open task manager', but actually didn't work. I set 'Show calendar', also no effect. Returned task manager, and only then it worked. Other options like show only on primary display and not to show tooltip worked as needed right after beeing enabled.
Here's the log:
log.txt

@marticliment marticliment added ready-to-go Ready to be fixed without further conversation and removed needs-author-answer Waiting for the author to answer. If author does not answer in 2 days, Issue gets closed labels Oct 4, 2022
@marticliment
Copy link
Owner

This issue has been fixed

@Rewerson
Copy link
Author

@martinet101
It seems I found how to reproduce this bug exactly. OS starts with russian keyboard layout, and when the program starts, no action on click (set to show calendar). If I switch keyboard layout to English and then restart ElevenClock, everything works fine.

In logs of the new version there is:
Action: ['win', 'n']

But actually that 'n' is incorrectly initialized when on other keyboard layout, where is no any 'n'.
As I said earlier, it happens with all actions, which are 'Win+[letter]'.

@marticliment
Copy link
Owner

So, what would be the russian shortcut for opening the calendar?

@Rewerson
Copy link
Author

On russian layout it's 'т' on key which is 'n' in English.
But it's strange that when starting with English layout, both Win+n and (if switch layout then) Win+т works both. And when with russian, neither Win+т, nor Win+n have effect.

@marticliment
Copy link
Owner

So, let's say you set the action to Win+R (run dialog) and then you navigated to %userprofile%/.elevenclock and edited a filed called 'CustomClickAction' (more or less. can't remember the name exactly.) You edited that file and replaced the R with the т, when you restarted ElevenClock, would it work?

@marticliment marticliment added the needs-author-answer Waiting for the author to answer. If author does not answer in 2 days, Issue gets closed label Oct 12, 2022
@marticliment marticliment reopened this Oct 12, 2022
@Rewerson
Copy link
Author

Rewerson commented Oct 12, 2022

Nope.
At first, when I edit CustomClickAction, there is warning like symbol U+0422 "Т" (or U+0442 "т", or any other cyrillic symbol) is not ASCII-char.
And then after reload the program, in log file I see no errors and previously set action.
So, that file seems malformed and is ignored after manual editing, maybe it's not designed to be in UTF-8.

@marticliment
Copy link
Owner

Hi @Rewerson, I'm afraid that the actual cause for this is the incompatibility of the pynput library. I'll further look at this but I don't think this will be easily fixable.

@marticliment marticliment added hard-one Idk if it is going to be possible to do that needs-further-study Needs further study and removed ready-to-go Ready to be fixed without further conversation needs-author-answer Waiting for the author to answer. If author does not answer in 2 days, Issue gets closed labels Oct 12, 2022
@marticliment marticliment mentioned this issue Oct 13, 2022
@marticliment marticliment changed the title [BUG/ISSUE] Clicking on the clock does nothing after system reboot [BUG/ISSUE] Clicking on the clock fails changing ime Oct 13, 2022
@marticliment marticliment changed the title [BUG/ISSUE] Clicking on the clock fails changing ime [BUG/ISSUE] Clicking on the clock fails when changing input method Oct 13, 2022
marticliment added a commit that referenced this issue Nov 10, 2022
@marticliment
Copy link
Owner

Could you please try this release?
https://github.com/martinet101/ElevenClock/releases/tag/3.9.3-r2

Make sure to enable the toggle listed in the release's description!

@Rewerson
Copy link
Author

Test results:
When start both with Eng and Rus keyboard layout and then click, opens Start menu (like it's pressed only Win button, not Win+N), and then clock closes without self-restarting.

@marticliment
Copy link
Owner

If you disable the toggle in the settings, it does work as ususal, right?

@Rewerson
Copy link
Author

Yep, without new setting, it works as usual (nothing when started with Rus, and calendar popup when keyboard layout on program start was Eng).

@marticliment
Copy link
Owner

With that functiomn disabled, could you please:

  1. Enable custom clock click action in the settings window and choose show calendar
  2. Go to your home folder and navigate to .elevenclock
  3. edit a file called CustomClockClickAction and replace Win+N for the kayboard shortcut you use to open the calendar flyout from the keyboard.
  4. Quit and launch ElevenClock
  5. Test again

@Rewerson
Copy link
Author

The same behaviour.
Tried Win+Т and Win+т in CustomClockClickAction file.

@marticliment
Copy link
Owner

All right. Then there's an incompatiblity with the library

@marticliment
Copy link
Owner

I'll see what i can do

@marticliment
Copy link
Owner

Hi,

could you please try this release (it is a new version)?

https://github.com/martinet101/ElevenClock/releases/tag/3.9.4-beta2

@Rewerson
Copy link
Author

Works even without new setting enabled, in CustomClockClickAction there is win+n.
But there are two new moments:

  1. There is small visual glitch to the left of clock when clicked:
    image
  2. No other hotkeys work, Win+D or Win+R actions ignored, nothing happens on click.

Seems like click is just passing to system clock that is under your custom clock, so calendar appears, as it works without ElevenClock started. But hotkeys are still broken themselves.

@marticliment
Copy link
Owner

This new version should have this fixed.

Could you please check?

https://github.com/martinet101/ElevenClock/releases/tag/3.9.4-beta3

@Rewerson
Copy link
Author

Now it's better. Actions work.

Current issues:

  1. Visual glitch described in previous post still presents.
  2. I tried all actions in settings list and two of them have problems:
    Open Start menu - opens menu, but ElevenClock closes.
    Show desktop - mutes/unmutes speakers, in CustomClockClickAction file there is Win+D, manually that shortcut works as needed.

@marticliment
Copy link
Owner

Open Start menu - opens menu, but ElevenClock closes.

This one is half broken and can't be fixed.

2. Show desktop - mutes/unmutes speakers, in CustomClockClickAction file there is Win+D, manually that shortcut works as needed.

I'll see what I can do

@marticliment
Copy link
Owner

Fixed!

marticliment added a commit that referenced this issue Nov 17, 2022
Fix an issue with the show desktop action (#923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hard-one Idk if it is going to be possible to do that needs-further-study Needs further study
Projects
None yet
Development

No branches or pull requests

2 participants