Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial not compatible with latest graph-tool 2.41 #35

Closed
alberto-bracci opened this issue Jul 1, 2021 · 7 comments
Closed

tutorial not compatible with latest graph-tool 2.41 #35

alberto-bracci opened this issue Jul 1, 2021 · 7 comments

Comments

@alberto-bracci
Copy link

Hi, I believe the multilayer_SBM notebook tutorial is not compatible with the latest graph-tool version.

In particular, when running the fit_hyperlink_text_hsb part, I simply get an error because the deg_corr and layers arguments in gt.minimize_nested_blockmodel_dl are not present any more.
By looking at graph-tool, it appears they were last present in 2.37 . Maybe you tested the code with earlier versions?

Just flagging because I saw the recently published paper on EPJDS, it looks great and I was looking forward to apply the methodology to our use case!

@count0
Copy link
Contributor

count0 commented Jul 1, 2021

I have already fixed this in my own repository, but forgot to push here... Will do so in a sec.

@count0
Copy link
Contributor

count0 commented Jul 1, 2021

The fix is in pull request #37 . Waiting for @martingerlach to merge.

@alberto-bracci
Copy link
Author

great, thanks for the rapid answer and commit!
From the linked commit it seems you edited the one layer versions of the model: sbmtm.py and TopSBM-tutorial.ipynb/html
Do these changes also propagate to the multilayer version, namely sbmmultilayer.py and Multilayer_SBM_Tutorial.ipynb ?
From the code they do not seem to share dependencies/code, but I maybe wrong

@martingerlach
Copy link
Owner

@alberto-bracci thanks for bringing up this issue. thanks @count0 for the fix, I just merged. I am closing this issue, but feel free to re-open if something is missing.

@alberto-bracci
Copy link
Author

I tried it with the multilayer version and I still get the same error.

A similar fix needs to be implemented in sbmmultilayer.py, and maybe also in the associated notebook Multilayer_SBM_Tutorial.ipynb to make the multilayer version run with the latest graph_tool version

Unfortunately it's my first approach to SBM and graph_tool, so I'm not sure how I can help

@alberto-bracci
Copy link
Author

I can still run it with an older version of graph_tool I guess, just wondering whether I would have other problems like performance drops or else

@count0
Copy link
Contributor

count0 commented Jul 6, 2021

This is fixed in PR #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants