Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance by making hashing work on streams #4

Closed
martinlindhe opened this issue Mar 9, 2019 · 3 comments
Closed

Improve performance by making hashing work on streams #4

martinlindhe opened this issue Mar 9, 2019 · 3 comments

Comments

@martinlindhe
Copy link
Owner

As brought up in #1 (comment), the hashing performance is not great when working on larger files.

The gohash code could be reworked to work on streams in many cases where the underlying hash libraries support it, giving us better performance.

Repository owner deleted a comment from sergeevabc Apr 18, 2019
Repository owner deleted a comment from sergeevabc Apr 18, 2019
@martinlindhe
Copy link
Owner Author

All supported hash algos now work using io.Copy()

@sergeevabc
Copy link

All supported hash algos now work using io.Copy()

It did not solve a performance issue described earlier.

@martinlindhe
Copy link
Owner Author

All supported hash algos now work using io.Copy()

It did not solve a performance issue described earlier.

Your earlier comment is about bad performance in the gost algorithm.
The implementation in use lives in another repository and are created by other people who are in better position of improving the performance.

This issue is about improving performance in gohash by using i/o streams where possible, which has now been resolved.

Repository owner locked as resolved and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants