Added thermal zone information and documentation #359
Conversation
There was a problem hiding this comment.
Hey @StewartThomson,
Thanks for giving this a go! I have some things that I'd like cleaned up, but mostly looks good 👍
|
Question though - does it seem to give proper data on your machine? I get seemingly constant temperatures of 301 Kelvin, even after running stress tests for a good while. |
Removed references to tcp in collector.thermalzone.md
|
Thanks for the review! I do get appropriate data. It matches up with what is displayed in Novabench, and temps go up appropriately when benchmarking. It may have something to do with the fact that the code isn't looping over all of the zones. Also, I wasn't sure if you guys modified the generated go files or not, but I'll make the changes described above on Monday. Have a good weekend! |
|
Excellent, thanks! |
…perature - Converted decikelvin to Celsius - Added a loop to get the values from each zone - Added documentation for percent passive limit and throttle reasons
|
Resolved the above comments Also added a name field to identify each thermalzone in the loop |
|
|
||
| Name | Description | Type | Labels | ||
| -----|-------------|------|------- | ||
| `wmi_thermalzone_percent_passive_limit` | % Passive Limit is the current limit this thermal zone is placing on the devices it controls. A limit of 100% indicates the devices are unconstrained. A limit of 0% indicates the devices are fully constrained. | gauge | None |
There was a problem hiding this comment.
Extra credit for great documentation 👍
For issue #73 This PR adds a go file for ThermalZoneInformation that was autogenerated by New-Collector.ps1