Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version number contained in files and Release as v0.6.1 (was: Update Conan recipe for v0.6.0) #47

Closed
3 tasks done
martinmoene opened this issue Jun 15, 2022 · 3 comments

Comments

@martinmoene
Copy link
Owner

martinmoene commented Jun 15, 2022

Per PR #46

  • Update Make new GitHub Release tag.
  • Update Conan recipe: Create PR.
  • Update Conan recipe: PR merged.
@striezel
Copy link
Contributor

Update GitHub Release tag

If that means that the old tag is deleted and another commit is tagged as v0.6.0, then be aware that this may cause some inconsistencies among existing forks and working copies of expected-lite. More details about why re-tagging can be problematic can be read in the official Git documentation: https://git-scm.com/docs/git-tag#_on_re_tagging

Bottom line is:

Git does not update tags in existing repositories when doing a git fetch or git pull. So anyone who has checked out the repository will still have the old v0.6.0 tag unless the tag is updated manually in that person's repository checkout. So it might be easier to just create a new tag (e. g. v0.6.1) and use that one instead, possibly pointing out that v0.6.0 has the wrong version in the code and should not be used anymore.

@martinmoene
Copy link
Owner Author

Thanks @striezel for your informed suggestion to do a/the sensible thing :)

@martinmoene martinmoene changed the title Update Conan recipe for v0.6.0 Fix version number contained in files and Release as v0.6.1 (was: Update Conan recipe for v0.6.0) Jun 28, 2022
@martinmoene
Copy link
Owner Author

Released v0.6.1 here and on Conan Center, closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants