Fix conversion and sign-conversion warnings. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only two of the fixes were for GSL itself, but since all conversion warnings have been fixed in the tests and these warnings have been enabled for the test suite, it should be easier to discover conversion warnings in GSL in the future.
|
Thanks @Sillamacka (ref. issue #59) |
martinmoene
reviewed
Apr 24, 2017
| @@ -59,7 +59,7 @@ elseif( "${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU" OR | |||
| target_compile_options( gsl-lite-cpp14.t PUBLIC -std=c++14 ) | |||
| endif() | |||
|
|
|||
| add_compile_options( -Wall -Wno-missing-braces -fno-elide-constructors ) | |||
| set ( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-missing-braces -fno-elide-constructors -Wconversion -Wsign-conversion -Wno-string-conversion" ) | |||
There was a problem hiding this comment.
What is the reason to change add_compile_options to set ?
There was a problem hiding this comment.
I'll be honest, I don't fully understand the difference, but when using add_compile_options no warnings were thrown and make VERBOSE=1 did not show the warning settings on the command line.
There was a problem hiding this comment.
I looked it up, this is the issue with add_compile_options:
Adds options to the compiler command line for targets in the current directory and below that are added after this command is invoked.
From this stack overflow answer
Isn't CMake wonderfully intuitive?
So it seems the CMakeLists.txt needs to be a bit rearranged in general to fix this.
martinmoene
added a commit
to martinmoene/lest
that referenced
this pull request
Apr 25, 2017
See also gsl-lite PR 71, gsl-lite/gsl-lite#71
martinmoene
added a commit
to martinmoene/lest
that referenced
this pull request
Apr 25, 2017
See also gsl-lite PR 71, gsl-lite/gsl-lite#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only two of the fixes were for GSL itself, but since all conversion warnings
have been fixed in the tests and these warnings have been enabled for the test
suite, it should be easier to discover conversion warnings in GSL in the future.