Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters preceding start code not ignored #16

Open
thomas-brunel opened this issue Dec 4, 2022 · 2 comments
Open

Characters preceding start code not ignored #16

thomas-brunel opened this issue Dec 4, 2022 · 2 comments

Comments

@thomas-brunel
Copy link
Contributor

Hi,

Not sure if this is still relevant, but from the wikipedia page of the Intel hex file format it is mentioned that all characters preceding the start code of a record should be ignored, which is not the case as of today. I have done a modification on my fork to do this, but I wanted to know if this is still relevant before doing a PR.

@martinmroz
Copy link
Owner

Honestly I'm not 100% sure what folks are using this for but they sure do seem to be using it so of course I'd be more than happy to make the change and publish a new version. I've got a couple of changes landed since the last release was cut from helpful folks like yourself, so it's about time!

@chrysn
Copy link

chrysn commented Jan 7, 2023

A special case of this are "comments", which would be (completely ignored) lines that do not contain the start code at all.

Currently, if a file contains // some text lines, ihex users such as probe-rs-cli reject this with "missing start code ':'", whereas other ihex consumers srec_cat tolerate them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants