fix: ensure Display impls of Expression and Value can not fail
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not public API since it might be removed again in favor of the changes proposed in #93. For now it's here to ensures that the `to_string` implementations of `Expression` and `Value` will never ever cause a panic. Since we cannot signal an error there, it's better to at least do best effort and return the formatted result even if identifiers are not valid.
martinohmann
changed the title
to_string_unchecked and strict_modeDisplay impls of Expression and Value never will emit an error
martinohmann
changed the title
Display impls of Expression and Value never will emit an errorDisplay impls of Expression and Value can not fail
martinohmann
changed the title
Display impls of Expression and Value can not failDisplay impls of Expression and Value can not fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
to_string_uncheckedto theformatmodule andstrict_modeoption to theFormatter.This is not public API since it might be removed again in favor of the changes proposed in #93. I'm undecided about the direction to go at the moment.
For now it's here to ensures that the
to_stringimplementations ofExpressionandValuewill never ever cause a panic. Since we cannot signal an error there, it's better to at least do best effort and return the formatted result even if identifiers are not valid.