no need to match handle_event in detail

martinrehfeld · Apr 24, 2012 · 2ca7fe9 · 2ca7fe9
1 parent ded21f4
commit 2ca7fe9
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 23 deletions.
diff --git a/src/elli_basicauth.erl b/src/elli_basicauth.erl
@@ -26,29 +26,7 @@ handle(Req, Config) ->
     end.
 
 
-handle_event(request_complete, [_Req, _ResponseCode, _ResponseHeaders,
+handle_event(_, _, _) ->
-                                _ResponseBody, _Timings], _Config) ->
-    ok;
-
-handle_event(request_throw, _, _Config) ->
-    ok;
-
-handle_event(request_exit, _, _Config) ->
-    ok;
-
-handle_event(request_error, _, _Config) ->
-    ok;
-
-handle_event(request_parse_error, [_Data], _Args) ->
-    ok;
-
-handle_event(client_closed, [_When], _Config) ->
-    ok;
-
-handle_event(client_timeout, [_When], _Config) ->
-    ok;
-
-handle_event(elli_startup, [], _Config) ->
     ok.
 
 

diff --git a/test/elli_basicauth_tests.erl b/test/elli_basicauth_tests.erl
@@ -58,6 +58,36 @@ invalid_credentials_test() ->
     meck:unload(elli_request).
 
 
+elli_handler_behaviour_test() ->
+    ?assertEqual(ok, elli_basicauth:handle_event(request_complete,
+                         [mock_request,
+                          mock_response_code,
+                          mock_response_headers,
+                          mock_response_body,
+                          mock_timings], mock_config)),
+
+    ?assertEqual(ok, elli_basicauth:handle_event(request_throw,
+                         mock_dummy, mock_config)),
+
+    ?assertEqual(ok, elli_basicauth:handle_event(request_exit,
+                         mock_dummy, mock_config)),
+
+    ?assertEqual(ok, elli_basicauth:handle_event(request_error,
+                         mock_dummy, mock_config)),
+
+    ?assertEqual(ok, elli_basicauth:handle_event(request_parse_error,
+                         [mock_data], mock_config)),
+
+    ?assertEqual(ok, elli_basicauth:handle_event(client_closed,
+                         [mock_when], mock_config)),
+
+    ?assertEqual(ok, elli_basicauth:handle_event(client_timeout,
+                         [mock_when], mock_config)),
+
+    ?assertEqual(ok, elli_basicauth:handle_event(elli_startup,
+                         [], mock_config)).
+
+
 %%
 %% HELPERS
 %%