Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source distfile weighs 58MB for 4.6.2 vs 22MB for previous versions #1250

Closed
danfe opened this issue Dec 10, 2023 · 3 comments
Closed

Source distfile weighs 58MB for 4.6.2 vs 22MB for previous versions #1250

danfe opened this issue Dec 10, 2023 · 3 comments
Assignees
@martinrotter
Labels
Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Milestone
4.6.3

Comments

@danfe
Copy link
Contributor

danfe commented Dec 10, 2023 •
edited

I've noticed that source code .tar.gz download from GitHub takes too long and eventually found out that it weighs more than twice now. Looking inside the contents, this is caused by bundled resources/scripts/libmpv which contains prebuilt Win32 DLL worth a little less than 100MB. May I suggest this library code fetched from elsewhere and injected into Windows release only? Having it inside the source code is conceptually wrong and is a gratuitous pessimization for users of Unix-like systems (larger distfile, longer download times).

P.S. Seeing is a (very) tiny feed reader in the About window now looks even more ironic. You should probably reword it as QtWebEngine component typically eats several gigabytes, often more than total amount of RAM and swap combined on my laptop.

Operating system and version

  • OS: FreeBSD 13.2
  • RSS Guard version: 4.6.2
@danfe danfe added the Type-Defect This is BUG!!! label Dec 10, 2023
@martinrotter
Copy link
Owner

Yes, i will move that into separate git submodule, sorry for that.

@martinrotter
Copy link
Owner

should be fixed in master branch, libmpv was added as submodule

@martinrotter martinrotter added this to the 4.6.3 milestone Dec 11, 2023
@martinrotter martinrotter added the Status-Fixed Ticket is resolved. label Dec 11, 2023
@danfe
Copy link
Contributor Author

danfe commented Dec 18, 2023

should be fixed in master branch

Distfile for v4.6.3 is back to normal size, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinrotter martinrotter

Labels
Status-Fixed Ticket is resolved. Type-Defect This is BUG!!!
Projects
None yet
Milestone
4.6.3
Development

No branches or pull requests
2 participants
@danfe @martinrotter