Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Auto-select article when article list gains focus #142

Closed
danowar2k opened this issue Sep 14, 2017 · 7 comments
Closed

FR: Auto-select article when article list gains focus #142

danowar2k opened this issue Sep 14, 2017 · 7 comments
Assignees
Labels
Milestone

Comments

@danowar2k
Copy link

danowar2k commented Sep 14, 2017

Brief description of the issue.

Just another feature request for better working with the keyboard.

The TAB order of the elements right now seems a little bit off. When the feed list has focus and you press TAB, it would be nice if the article list gains focus. But right it seems (!) that this isn't the case. What happens is you press TAB, then nothing seems to have focus. Then you move with the arrows and you see that the article list HAS gained focus but nothing was selected.
Ergo it would be nice if you would always auto-select an article...?

@danowar2k danowar2k changed the title FR: Using Tab or some other key to move between article list and feed list FR: Auto-select article when article list gains focus Sep 14, 2017
@martinrotter martinrotter self-assigned this Sep 15, 2017
@martinrotter martinrotter added Component-Feed-List Component-GUI Component-Message-List Priority-Low I not personally interested in this ticket, perhaps others might prepare PR. Status-Accepted I will eventually implement this. Type-Enhancement This is request for brand new feature. labels Oct 22, 2017
@martinrotter martinrotter added this to the 3.5.4 milestone Oct 22, 2017
@martinrotter
Copy link
Owner

Hello, yes, the tab order is correct. I tried to fix this. Please test latest development build and let me know your results.

ad36c34

@martinrotter martinrotter reopened this Oct 22, 2017
@danowar2k
Copy link
Author

Hi, I tried the dev build at https://transfer.sh/1yTAc/rssguard-3.5.4-35bb9c9-win64.7z

Didn't work quite right.
I tabbed to the article list, no article was selected.
I arrowed down, second article was selected.
I tabbed back to the feed list, a feed was selected.
I tabbed back to the article list, the last selected article was selected.

@martinrotter
Copy link
Owner

Try this one https://transfer.sh/13Mmlj/rssguard-3.5.4-598b591-win64.7z .
You were trying bad development build (the one without fix).

@danowar2k
Copy link
Author

Okay, downloading...
Could you do something about the layout of the page? https://github.com/martinrotter/rssguard/wiki/Windows-development-builds
Somehow there seem to be no newlines. Also, I'd propose to sort the builds below date headers, like:

2017-10-10:
2017-10-10_cj45tjd-3.5.4.7z
2017-10-10_fg452jd-3.5.4.7z

Or something like that. And maybe sort by date decreasing, so you have the latest builds on top?

@danowar2k
Copy link
Author

That build's much better, though. Tabbing now selects the first article in the list. :-)

@martinrotter
Copy link
Owner

Yea, I will eventually sort out better layout for those wiki pages.

So the issue is solved? Can I mark as fixed?

@danowar2k
Copy link
Author

Yep, I can confirm this is fixed now.

@martinrotter martinrotter added Status-Fixed Ticket is resolved. and removed Priority-Low I not personally interested in this ticket, perhaps others might prepare PR. Status-Accepted I will eventually implement this. labels Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants