Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure against Qt 5.14 (missing header) #223

Closed
a17r opened this issue Jan 5, 2020 · 1 comment
Closed

Build failure against Qt 5.14 (missing header) #223

a17r opened this issue Jan 5, 2020 · 1 comment
Assignees
Labels
Status-Fixed Ticket is resolved. Type-Deployment Problem is caused by badly deployed application files.
Milestone

Comments

@a17r
Copy link

a17r commented Jan 5, 2020

Brief description of the issue.

Probably due to some header cleanup, build fails without including QKeyEvent to (at least) messagepreviewer.cpp.

How to reproduce the bug?

Try to build against Qt-5.14.0.

What actually happened?

build.log

gui/messagepreviewer.cpp: In member function ‘virtual bool MessagePreviewer::eventFilter(QObject*, QEvent*)’:
gui/messagepreviewer.cpp:206:57: error: invalid static_cast from type ‘QEvent*’ to type ‘QKeyEvent*’
  206 |     QKeyEvent* key_event = static_cast<QKeyEvent*>(event);
      |                                                         ^
In file included from /usr/include/qt5/QtWidgets/QWidget:1,
                 from ./gui/messagepreviewer.h:6,
                 from gui/messagepreviewer.cpp:3:
/usr/include/qt5/QtWidgets/qwidget.h:75:7: note: class type ‘QKeyEvent’ is incomplete
   75 | class QKeyEvent;
      |       ^~~~~~~~~
gui/messagepreviewer.cpp:208:18: error: invalid use of incomplete type ‘class QKeyEvent’
  208 |     if (key_event->matches(QKeySequence::StandardKey::Find)) {
      |                  ^~
In file included from /usr/include/qt5/QtWidgets/QWidget:1,
                 from ./gui/messagepreviewer.h:6,
                 from gui/messagepreviewer.cpp:3:
/usr/include/qt5/QtWidgets/qwidget.h:75:7: note: forward declaration of ‘class QKeyEvent’
   75 | class QKeyEvent;
      |       ^~~~~~~~~
make[1]: *** [Makefile:6510: messagepreviewer.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/var/tmp/portage/net-news/rssguard-9999/work/rssguard-9999/src/librssguard'
make: *** [Makefile:48: sub-src-librssguard-make_first-ordered] Error 2
@martinrotter
Copy link
Owner

should be fixed now

@martinrotter martinrotter self-assigned this Apr 17, 2020
@martinrotter martinrotter added Status-Fixed Ticket is resolved. Type-Deployment Problem is caused by badly deployed application files. labels Apr 17, 2020
@martinrotter martinrotter added this to the 3.6.0 milestone Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status-Fixed Ticket is resolved. Type-Deployment Problem is caused by badly deployed application files.
Projects
None yet
Development

No branches or pull requests

2 participants