Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show MRSS images directly next to or inline the article; Help or feature request? #39

Closed
groentebroer opened this issue Jul 22, 2016 · 8 comments
Assignees
Labels
Component-GUI Component-Message-List Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Milestone

Comments

@groentebroer
Copy link

Brief description of the issue.

I can't seem to find out how to show an "attached" image via MRSS to directly be shown next to the item. Is this possible? Or would that be a new feature request?

How to reproduce the bug?

Not applicable

What is the expected result?

Image or images shown next to the article.

What actually happened?

Per item downloading the attachment works.

Other information (logs, see Wiki)

None.

@martinrotter
Copy link
Owner

You mean, if RSS/ATOM message contains (let's say) PNG or JPG image, show it directly somewhere in the message preview? For example under the title?

@martinrotter martinrotter self-assigned this Jul 25, 2016
@groentebroer
Copy link
Author

Yes, if the message contains an attachment which is of type "image" Indeed in the preview. Under the title could be nice.

It would be to support these tags in the preview:

<enclosure type="image/*" />
or
<media:content type="image/*" >

Some (non-official) reference: https://help.campaignmonitor.com/topic.aspx?t=277

@martinrotter
Copy link
Owner

Yes, now it makes sense, thank you.

This issue itself is really easy to implement. I will have to think a bit about skins. Now, each skins specifies its own markup/stylesheet for displaying individual messages, I will have to tweak the skinning methods a bit to allow this.

@martinrotter martinrotter added this to the 3.3.3 milestone Jul 27, 2016
@martinrotter martinrotter added the Status-Fixed Ticket is resolved. label Jul 27, 2016
@martinrotter
Copy link
Owner

rssg

See the picture and let me know if this is good enought. I highlighted the interesting area with red rectangle. If message contained more images, they would be shown next to each other. Shown image is thumbnail, user can click it and see full-size original image.

Is this enough?

@groentebroer
Copy link
Author

Looks great already!
Thanks for the fast fix. I will give it a try when 3.3.3 is available for download! Any ETA?

@martinrotter
Copy link
Owner

Okay. Last question: Would it be better that images are placed below the actual message? Or current look is enough?

@groentebroer
Copy link
Author

groentebroer commented Aug 2, 2016

In my personal opinion it is best this way. An image says more then 1000 words ;-). I think the image would/should trigger you to read the item. Scanning items will be easier based on the image.
So this is preferrable over below the article, if you ask me.

@martinrotter
Copy link
Owner

Okay, then this is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-GUI Component-Message-List Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Projects
None yet
Development

No branches or pull requests

2 participants