Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starlight sidebar badges outlined style issue #77

Closed
1 task
HiDeoo opened this issue Apr 18, 2024 · 3 comments
Closed
1 task

Starlight sidebar badges outlined style issue #77

HiDeoo opened this issue Apr 18, 2024 · 3 comments

Comments

@HiDeoo
Copy link

HiDeoo commented Apr 18, 2024

Describe the Bug

Note: the issue has initially been reported in withastro/starlight#1764

  1. Navigate to https://events-3bg.pages.dev/jotter/history-of-changes/ and notice the sidebar entry for this page containing a badge with an outlined style as expected for the current page:
SCR-20240418-kszb
  1. Navigate with a full navigation to https://events-3bg.pages.dev/jotter/ and notice the sidebar entry for the previous page ("Recent changes") with a colored badge as expected as it's not the current page:
image
  1. Navigate to the "Recent changes" page using the sidebar link and notice that the sidebar badge is not updated to an outlined style as expected for the current page:
image

What's the expected result?

The sidebar badges should be updated to an outlined style when the page is the current one (and vice versa when it's no longer the current one).

Link to Minimal Reproducible Example

https://events-3bg.pages.dev/jotter/history-of-changes/

Participation

  • I am willing to submit a pull request for this issue.
@martrapp
Copy link
Owner

Hi @HiDeoo, really great that you have posted the detailed issue! A reference to the Starlight issue would have sufficed, but of course it's much easier for me to understand this way. Thank you very much for that, I really appreciate it.

@martrapp
Copy link
Owner

Lots of options, see withastro/starlight#1764. Looks like this issue will be closed by withastro/starlight#1530 😄

@martrapp
Copy link
Owner

martrapp commented Jun 5, 2024

Closed after withastro/starlight#1530 was merged

@martrapp martrapp closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants