Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting imageUrl in some cases #16

Closed
RakeshImpinge opened this issue Sep 13, 2016 · 6 comments
Closed

Not getting imageUrl in some cases #16

RakeshImpinge opened this issue Sep 13, 2016 · 6 comments

Comments

@RakeshImpinge
Copy link

RakeshImpinge commented Sep 13, 2016

Thanks for this great library.
I am facing a problem in getting "imageUrl" for some case.

http://www.runnersworld.com/race-training/how-to-taper-for-your-first-half-marathon?utm_source=facebook.com&utm_medium=Social&utm_term=580876710&utm_campaign=Runner%E2%80%99s%20World

I am using OGDataProvider to extract the data.
[[OGDataProvider sharedInstance] fetchOGDataWithUrlString:url completion:^(OGData data, NSError error)

Any help is much appreciated.

@marty-suzuki
Copy link
Owner

Thank you for a issue.

Please see the html of http://www.runnersworld.com/race-training/how-to-taper-for-your-first-half-marathon?utm_source=facebook.com&utm_medium=Social&utm_term=580876710&utm_campaign=Runner%E2%80%99s%20World

This html doesn't have<meta property="og:image" content="http://~" />
Therefore can't get image.

@RakeshImpinge
Copy link
Author

Thanks for prompt reply.
If you paste the same URL in Skype or Facebook they are displaying the Image.
Is this something this library does not support?

@marty-suzuki
Copy link
Owner

marty-suzuki commented Sep 13, 2016

I think they search image from html when can't find og:image. In addition, I think they gather OGP data with server.
If og:image doesn't be contained in html, it is difficult to get matched image for the web site.
That image might be AD image, header image and so on.

@RakeshImpinge
Copy link
Author

I see. Thanks for the description.

@marty-suzuki
Copy link
Owner

Sorry that I can't live up to your expectations.

@RakeshImpinge
Copy link
Author

No Problem @marty-suzuki. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants