Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging configuration #3

Open
ottowayi opened this issue Aug 8, 2022 · 1 comment
Open

Remove logging configuration #3

ottowayi opened this issue Aug 8, 2022 · 1 comment

Comments

@ottowayi
Copy link

ottowayi commented Aug 8, 2022

in client.py logging.basicConfig is called on line 19, this configures the root logger with a default stderr stream handler. By doing this, it means any other calls to basicConfig are ignored. This leads to users having to call basicConfig before importing aonvif or other work arounds. In my case, I'm not using basicConfig, so I end up with duplicate log entries in my terminal just from importing the library. Please remove this or it might be better to move it to the CLI startup. That way there still is default logging for using the CLI, but removes the logging side effects from importing.

@martyanov
Copy link
Owner

@ottowayi thanks for the report. Colud your please create a PR with the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants