Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow session authentication with the @requires_indieauth decorator #4

Closed
capjamesg opened this issue Sep 11, 2021 · 1 comment
Closed

Comments

@capjamesg
Copy link

The @requires_indieauth decorator does not currently support reading access tokens from session storage. I was wondering if this is something you had considered adding to the Flask-IndieAuth extension at some point.

I am not as aware of the security ramifications of such an implementation. But, I would love to start a discussion around whether Flask-IndieAuth could add a rule that lets one authenticate if session["access_token"] is present. This would let someone view any web resource (i.e. a HTML page or a JSON file) in their browser using the Flask-IndieAuth extension.

@martymcguire
Copy link
Owner

thanks, @capjamesg !

This library is built specifically for use cases like Micropub endpoints that need to check the authentication of a POST where the access token is in an Authorization HTTP header or in the body parameters of that POST. It doesn't have a concept for persistent sessions, which I consider outside the scope of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants