Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.addListener("message#Channel" bug #169

Closed
sigmatht opened this issue May 15, 2013 · 2 comments
Closed

client.addListener("message#Channel" bug #169

sigmatht opened this issue May 15, 2013 · 2 comments

Comments

@sigmatht
Copy link

Just came across this lil bug. I have:

client.addListener("message#channel", function(){};

When someone joins #channel and types something, that message is correctly handled by the listener. However, if someone joins #Channel or #cHannEL, etc (with caps in it, it directs them to same room), but the Listener won't even notice their message. Most IRC clients I believe correct the channel room name for their clients; however, I noticed specifically with mibbit web irc client that it doesn't--So I'm not sure if there are other clients out there as well that could fail to do this. Either way, is there a way to correct this in the node-irc lib?

@quentinxs
Copy link
Contributor

I personally haven't used the message#channel listener yet, but I have noticed that issue. Though I am currently unaware of any case-sensitive networks, I didn't want to change the library just in case one does exist. My workaround was to display the target (channel or nick) name to the user as typed, but, in the client, convert all message targets to lowercase before determining where on the page or whether to display it.

@sigmatht
Copy link
Author

Thanks for the reply qsheets. I think I've figured it out. If I keep the #channel lowercase it won't run into those issues. Its when I type the channel as #Channel that it has those issues. So message#channel will recognize #Chanel and #chaNNEl and #channel. But message#Channel will just recognize #Channel.

@osslate osslate closed this as completed May 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants