Error Handling Improvements (all errors should gracefully fail)

[ghost]

I purpose to improve error handling to prevent crashing as much as programmatically possible during normal operations.

[moshmage]

In regards to #419, shouldn't a case: 'NICK' be fired?

On topic: Are we talking about just.. wrapping the whole thing into a try, catch and add checks on top of each case and finally throw them back?

[ghost]

Lines: 747-753:

747:            try {
                    self.emit('raw', message);
                } catch (err) {
                    if (!self.conn.requestedDisconnect) {
                        throw err;
                    }
753:           }

At a minimum what I'm thinking is we take these lines and instead of throwing an error after the hail mary, we send the error message to console, and make a threshold. If we see 3-5 errors in less then 5 seconds then we throw the err.

To your idea, maybe wrapping try catch to every case would be a good idea. It might help vet out other things, possibly a good excuse to crawl through the code again.

[moshmage]

I'd do a "lets first close all the PRs" motion before handling this refactor, but we are on the same page on this one :)

[ghost]

Fine by me.