can you not name your patches like this kthnx #532
Comments
|
https://github.com/martynsmith/node-irc/commits/master I dont see commits with the names you describe. I also don't see pull requests named the way you describe. And I dont see any patch files in the repo anywhere. https://github.com/martynsmith/node-irc/graphs/contributors And I don't see the user you mention anywhere in the contributors list. So.... what are you on about? |
|
Feel free not to use it :D |
|
You're given the opportunity to make use of an awesome project for free and you choose to instead nitpick like they owe you anything. Real classy. |
|
I'd call it constructive criticism if there really were a bunch of poorly named commits like that, but ... there... aren't? o.0 |
|
He is upset I did not spend the time putting work in commit notes for a fork I did not really intend to share, because logic. I took a look at his github profile, 0 contributions, I bet there are an infinite amount of ungrateful remarks how ever. |
|
For a teaching moment: If you are upset my fork is not clear, feel free to read the commits and add some notes to them, that way you are actually contributing to open source, and your input has value. |
os I saw you're using node-irc and was like oh cool, i'll take your fork it looks like it has a ton of patches then I saw these:
@davericher
literally can you not, please. atleast in the future.
The text was updated successfully, but these errors were encountered: