Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIT, KILL removes users from user list before processing event hooks #73

Closed
awwright opened this issue Nov 24, 2011 · 2 comments
Closed

Comments

@awwright
Copy link

The default 'raw' event hook is executed before anything else, which removes. It emits a 'quit' event which lists the removed users, however other commands (KILL, NICK) have no way of knowing what the affected channels are. Additionally with the current 'quit' event there is no way to get the raw parsed packet AND the list of channels the user was in. Perhaps the data structures should not be modified until all event hooks have been fully processed.

@MrSam
Copy link

MrSam commented Jun 22, 2014

May be related to #243 ?

@ghost
Copy link

ghost commented Sep 4, 2015

Since #242 has been closed, i believe events were added in a previous code rewrite.

I suggest this be closed.

@jirwin jirwin closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants