Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs option for setting cdn version #4

Closed
coreypmurphy opened this issue Nov 28, 2016 · 1 comment
Closed

Needs option for setting cdn version #4

coreypmurphy opened this issue Nov 28, 2016 · 1 comment

Comments

@coreypmurphy
Copy link
Contributor

coreypmurphy commented Nov 28, 2016

Add-on is pointing at specific release of Tinymce via their cdn and is therefor hidden from modification by the app owner/dev. Would be good to have an addtional option to set in the environment.js besides "load: true", that allows setting the version to fetch from the cdn. Currently, the add-on is pointing at 4, which isn't a bad thing since it's following semver, except Tinymce released 4.5.0 this past weekend and caused ordered/unordered list buttons to suddenly disappear from the toolbar. They've not yet acknowledged this issue but being able to specify a release version in our ember apps would help devs to control add-on updating which we're already accustomed to doing in our package and bower json files.

Pull request #5 submitted.

@marucjmar
Copy link
Owner

Good idea, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants