forked from openshift/library-go
/
observe_featuregates.go
134 lines (116 loc) · 4.29 KB
/
observe_featuregates.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
package featuregates
import (
"fmt"
"reflect"
"strings"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/util/sets"
configv1 "github.com/openshift/api/config/v1"
configlistersv1 "github.com/openshift/client-go/config/listers/config/v1"
"github.com/openshift/library-go/pkg/operator/configobserver"
"github.com/openshift/library-go/pkg/operator/events"
)
type FeatureGateLister interface {
FeatureGateLister() configlistersv1.FeatureGateLister
}
func NewObserveFeatureFlagsFunc(knownFeatures sets.String, configPath []string) configobserver.ObserveConfigFunc {
return (&featureFlags{
allowAll: len(knownFeatures) == 0,
knownFeatures: knownFeatures,
configPath: configPath,
}).ObserveFeatureFlags
}
type featureFlags struct {
allowAll bool
knownFeatures sets.String
configPath []string
}
// ObserveFeatureFlags fills in --feature-flags for the kube-apiserver
func (f *featureFlags) ObserveFeatureFlags(genericListers configobserver.Listers, recorder events.Recorder, existingConfig map[string]interface{}) (map[string]interface{}, []error) {
listers := genericListers.(FeatureGateLister)
errs := []error{}
prevObservedConfig := map[string]interface{}{}
currentConfigValue, _, err := unstructured.NestedStringSlice(existingConfig, f.configPath...)
if err != nil {
errs = append(errs, err)
}
if len(currentConfigValue) > 0 {
if err := unstructured.SetNestedStringSlice(prevObservedConfig, currentConfigValue, f.configPath...); err != nil {
errs = append(errs, err)
}
}
observedConfig := map[string]interface{}{}
configResource, err := listers.FeatureGateLister().Get("cluster")
// if we have no featuregate, then the installer and MCO probably still have way to reconcile certain custom resources
// we will assume that this means the same as default and hope for the best
if apierrors.IsNotFound(err) {
configResource = &configv1.FeatureGate{
Spec: configv1.FeatureGateSpec{
FeatureGateSelection: configv1.FeatureGateSelection{
FeatureSet: configv1.Default,
},
},
}
} else if err != nil {
errs = append(errs, err)
return prevObservedConfig, errs
}
newConfigValue, err := f.getWhitelistedFeatureNames(configResource)
if err != nil {
errs = append(errs, err)
return prevObservedConfig, errs
}
if !reflect.DeepEqual(currentConfigValue, newConfigValue) {
recorder.Eventf("ObserveFeatureFlagsUpdated", "Updated %v to %s", strings.Join(f.configPath, "."), strings.Join(newConfigValue, ","))
}
if err := unstructured.SetNestedStringSlice(observedConfig, newConfigValue, f.configPath...); err != nil {
recorder.Warningf("ObserveFeatureFlags", "Failed setting %v: %v", strings.Join(f.configPath, "."), err)
errs = append(errs, err)
}
return observedConfig, errs
}
func (f *featureFlags) getWhitelistedFeatureNames(fg *configv1.FeatureGate) ([]string, error) {
var err error
newConfigValue := []string{}
enabledFeatures := []string{}
disabledFeatures := []string{}
formatEnabledFunc := func(fs string) string {
return fmt.Sprintf("%s=true", fs)
}
formatDisabledFunc := func(fs string) string {
return fmt.Sprintf("%s=false", fs)
}
enabledFeatures, disabledFeatures, err = getFeaturesFromTheSpec(fg)
if err != nil {
return nil, err
}
for _, enable := range enabledFeatures {
// only add whitelisted feature flags
if !f.allowAll && !f.knownFeatures.Has(enable) {
continue
}
newConfigValue = append(newConfigValue, formatEnabledFunc(enable))
}
for _, disable := range disabledFeatures {
// only add whitelisted feature flags
if !f.allowAll && !f.knownFeatures.Has(disable) {
continue
}
newConfigValue = append(newConfigValue, formatDisabledFunc(disable))
}
return newConfigValue, nil
}
func getFeaturesFromTheSpec(fg *configv1.FeatureGate) ([]string, []string, error) {
if fg.Spec.FeatureSet == configv1.CustomNoUpgrade {
if fg.Spec.FeatureGateSelection.CustomNoUpgrade != nil {
return fg.Spec.FeatureGateSelection.CustomNoUpgrade.Enabled, fg.Spec.FeatureGateSelection.CustomNoUpgrade.Disabled, nil
}
return []string{}, []string{}, nil
}
featureSet, ok := configv1.FeatureSets[fg.Spec.FeatureSet]
if !ok {
return []string{}, []string{}, fmt.Errorf(".spec.featureSet %q not found", featureSet)
}
return featureSet.Enabled, featureSet.Disabled, nil
}