Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a build fail, the test run still succeeds #53

Open
BenoitZugmeyer opened this issue Nov 30, 2022 · 2 comments
Open

When a build fail, the test run still succeeds #53

BenoitZugmeyer opened this issue Nov 30, 2022 · 2 comments

Comments

@BenoitZugmeyer
Copy link

When the build fail, for example because of a syntax error, karma-esbuild replaces it with a console.error, but does not fail the run. While it might be a good thing when running tests locally, it might be an issue in CI environments where we rely on test run exit status rather than error logs.

Would it be possible to fail the test run when a build fails?

@oriSomething
Copy link

Agree it should fail. Moreover, example to this kind of code that causes fail gracefully:

it("whatever", function() {
  export default "error";
});

@jridgewell
Copy link
Collaborator

Yup, please open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants