Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not require import paths on build tag'd files #7

Closed
djui opened this issue Apr 17, 2019 · 1 comment
Closed

Does not require import paths on build tag'd files #7

djui opened this issue Apr 17, 2019 · 1 comment

Comments

@djui
Copy link

djui commented Apr 17, 2019

If a file (e.g. foo_test.go) includes //+build integration, it won't touch it to rewrite it.

@marwan-at-work
Copy link
Owner

marwan-at-work commented Apr 17, 2019

@djui thanks for bringing this up.

I added a new flag so you can do mod upgrade -buildflags=-tags=integration

This is because the go compiler has no option to parse all go files so we have to be explicit about the build tags.

I'll think about whether it's worth replacing go/packages with manual parsing of go files so that we avoid having to explicitly pass -buildflags

I might also think about replacing -buildflags with just -tags=one,two,three to make the mod API a little bit nicer. Let me know what you think :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants