Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code no longer compiles #2

Closed
coder543 opened this issue Oct 13, 2017 · 5 comments
Closed

Code no longer compiles #2

coder543 opened this issue Oct 13, 2017 · 5 comments

Comments

@coder543
Copy link

This got referenced over here, and it is an interesting project. Unfortunately, the code seems to pre-date stable Rust v1.0, which means a lot of it is broken.

You probably have other priorities, I just figured I would make a note here that the code has bitrotted, until such time as anyone steps up to fix it.

@Marwes
Copy link
Owner

Marwes commented Oct 13, 2017

That should teach me to assume things :) (last paragraph).

Fixed with 9a15b01 (small regression due to a fix in rustc after 1.0)

@Marwes Marwes closed this as completed Oct 13, 2017
@coder543
Copy link
Author

coder543 commented Oct 13, 2017

sadly, this doesn't fix it.

errors

compiling with rustc 1.22.0-nightly (a47c9f870 2017-10-11)

using cargo run --release

@Marwes
Copy link
Owner

Marwes commented Oct 13, 2017

Woops. Only ran cargo test, that error only occurs with cargo build. That error may actually have been there since before 1.0.

@Marwes
Copy link
Owner

Marwes commented Oct 13, 2017

Now it builds as well 997a8b6.

Tested evaluating some programs and it appears that just writing 1 into the repl crashes it which I believe is because I never implemented type defaulting (ie transform Num a => a into Int). As long as the type is concrete it appears to work though.

@coder543
Copy link
Author

Yep, it works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants