Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-unused-outer-class is very restrictive on what it removes #112

Open
aeubanks opened this issue May 9, 2023 · 1 comment
Open

Comments

@aeubanks
Copy link

aeubanks commented May 9, 2023

remove-unused-outer-class seems very restrictive on when it'll consider a class for removal. It won't consider classes with templates or a base class.

There are many times where the code doesn't compile if you remove a template param or a base class and doesn't pass the interestingness test, but the class isn't referenced otherwise and is fine to completely remove.

Any thoughts?

@marxin
Copy link
Owner

marxin commented May 10, 2023

Sure, please create a pull request where you would relax the restrictions and add new test-cases for the situations you are interested in.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants