Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add natvis file to cmake install rules #106

Merged
merged 2 commits into from May 24, 2021

Conversation

Ryan-rsm-McKenzie
Copy link
Contributor

What does this change do?

This ensures the natvis file is installed in addition to the header files.

Is it related to an exisiting bug report or feature request?

Nope.

Pre-merge checklist

  • I've read CONTRIBUTING.md
  • I've rebased my changes against the current HEAD of origin/master (if necessary)
  • I've added new test cases to verify my change
  • I've regenerated toml.hpp (how-to)
  • I've updated any affected documentation
  • I've rebuilt and run the tests with at least one of:
    • Clang 6 or higher
    • GCC 7 or higher
    • MSVC 19.20 (Visual Studio 2019) or higher
  • I've added my name to the list of contributors in README.md

Ideally the meson script would also install the natvis file, but I don't anything about meson.
For reference, (by default) this installs it into <some-install-path>/share/tomlplusplus/toml++.natvis.

@marzer
Copy link
Owner

marzer commented May 24, 2021

Oh, great idea! Thanks for adding this.

@marzer marzer merged commit 42fa655 into marzer:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants