Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang 10.0: error: unknown warning group '-Wsuggest-destructor-override' #145 #146

Merged
merged 4 commits into from Mar 14, 2022
Merged

Conversation

chronoxor
Copy link
Contributor

@chronoxor chronoxor commented Mar 14, 2022

  • I've read CONTRIBUTING.md
  • I've rebased my changes against the current HEAD of origin/master (if necessary)
  • I've added new test cases to verify my change
  • I've regenerated toml.hpp (how-to)
  • I've updated any affected documentation
  • I've rebuilt and run the tests with at least one of:
    • Clang 6 or higher
    • GCC 7 or higher
    • MSVC 19.20 (Visual Studio 2019) or higher
  • I've added my name to the list of contributors in README.md

@marzer
Copy link
Owner

marzer commented Mar 14, 2022

Hi, thanks for the contribution! Looks good to me, but before I can merge you'll need to also regenerate the single-header version of the library (see CONTRIBUTING.md for info).

@chronoxor
Copy link
Contributor Author

Single header toml.hpp generated and provided!

@chronoxor
Copy link
Contributor Author

Also I can confirm that now toml++ module compiles fine on all latest major platforms in github-actions:
image

@chronoxor
Copy link
Contributor Author

Also provided a fix for MinGW platform

@chronoxor
Copy link
Contributor Author

MinGW compiles fine as well
image

@chronoxor chronoxor requested a review from marzer March 14, 2022 10:20
@marzer marzer merged commit 31cf6ef into marzer:master Mar 14, 2022
@marzer
Copy link
Owner

marzer commented Mar 14, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants