Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more VS debug visualizers #46

Merged
merged 1 commit into from Jul 19, 2020
Merged

Conversation

Reedbeta
Copy link
Contributor

Hello! I've added debug visualizers for toml::table, toml::array, and the parse_result and parse_error types that show up when using the non-exceptions build of the library. These mainly just cut down on visual clutter in the watch window.

Here's what a table looks like with the new visualizers:
image

For comparison, this is what it looked like before:
image

This is what parse_result looks like with a successful parse:
image

And this is what it looks like with an error:
image

Hope this is useful to others!

- Added natvis entries for toml::table, toml::array, parse_result, and parse_error
@marzer
Copy link
Owner

marzer commented Jul 19, 2020

Oh, fantastic! I was planning on doing this eventually, but debugging natvis is such a PITA... very happy for someone to have done that for me, so thanks :)

@marzer marzer merged commit a9a748e into marzer:master Jul 19, 2020
@Reedbeta
Copy link
Contributor Author

Thanks, happy to help! Natvis is a lot easier now that you can turn on its diagnostic messages and live-edit it during a debugging session. :)

@marzer
Copy link
Owner

marzer commented Jul 19, 2020

also, TIL you can reinterpret_cast<> in natvis

@Reedbeta Reedbeta deleted the more-natvis branch July 20, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants