Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATTiny85 compatibility #45

Closed
JelmerT opened this issue Jan 15, 2017 · 7 comments
Closed

ATTiny85 compatibility #45

JelmerT opened this issue Jan 15, 2017 · 7 comments
Assignees
Labels
bug Identifies a bug in the current version of the code
Milestone

Comments

@JelmerT
Copy link

JelmerT commented Jan 15, 2017

I'm trying to compile the library on an ATTiny85 (adafruit trinket), and I'm getting quite some errors.

for example:

SPIFlash/defines.h:81:12: error: 'SS' was not declared in this scope
#define CS SS

I can tell there are some checks for AVR_ATtiny85 in the library, but I can't make the standard examples work out of the box. Am I missing something? Or has ATTiny support not been tested in a while?

@Marzogh
Copy link
Owner

Marzogh commented Apr 12, 2017

Hi @JelmerT

Thank you for pointing this out. I have actually been a bit lazy w.r.t testing ATTiny support for the last release, but, I will fix this with the upcoming 2.6.0 release.
Also, my apologies for the late reply. Work has been eating up my time for the last few months and I've only just gotten back into looking at this library.

Cheers!

@Marzogh Marzogh self-assigned this Apr 12, 2017
@Marzogh Marzogh added the bug Identifies a bug in the current version of the code label Apr 12, 2017
@Marzogh Marzogh added this to the 2.6.0 milestone Apr 12, 2017
@JelmerT
Copy link
Author

JelmerT commented Apr 12, 2017

Thanks @Marzogh ! Sounds great 👍

@Marzogh
Copy link
Owner

Marzogh commented Apr 15, 2017

I'm afraid it looks like a lot has fallen through the gaps with the last release. I'm going to have to push support for the ATTiny85 back to v2.7.0 I'm afraid. v2.6.0 has some important bugfixes that need to be released asap. Sorry! I'm already working on the changes and should have it out before the end of the month.

@Marzogh Marzogh modified the milestones: 2.7.0, 2.6.0 Apr 15, 2017
@JelmerT
Copy link
Author

JelmerT commented Apr 16, 2017

👍

@Marzogh
Copy link
Owner

Marzogh commented Apr 19, 2017

Hey mate, ATTiny85 compatibility is all good to go as of today's commit on the ATTiny-compat-w.i.p branch. I'm working on polishing up a proper diagnostics example for this so you can compile and run it on the ATtiny85 to check everything's a-ok. For now, feel free to use the tinyFlashTester.ino as a rough test sketch. Once its all sorted and tested with the other boards as well, I'll roll this out into v2.7.0.

@JelmerT
Copy link
Author

JelmerT commented Apr 22, 2017

Great news! Will test and report back, might take some time though, thanks for this.

@Marzogh
Copy link
Owner

Marzogh commented Aug 2, 2017

Testing works fine at my end - I've tested with a 8MHz 3.3V trinket. So, I've rolled this into the 2.7.0 release along with Arduino Zero compatibility. Please let me know if you face any issues in the future.

@Marzogh Marzogh closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug in the current version of the code
Projects
None yet
Development

No branches or pull requests

2 participants