Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update the "mpv_thumbnail_script_client_osc" to a newer version of the "osc.lua", so it displays the chapter's name when hovering #9

Closed
ThomasEricB opened this issue Dec 27, 2021 · 6 comments

Comments

@ThomasEricB
Copy link

ThomasEricB commented Dec 27, 2021

https://github.com/mpv-player/mpv/commits/76b1ac57a4f49ff2c7f18b7e46aefa7fb3362984/player/lua/osc.lua

@ThomasEricB
Copy link
Author

ThomasEricB commented Dec 27, 2021

MPV recently updated their osc.lua to finally add chapter name display when hovering with the mouse (see commit 76b1ac57a4f49ff2c7f18b7e46aefa7fb3362984). Please consider upgrading the script's osc so it can perform this function!

@marzzzello
Copy link
Owner

Yeah, thanks for the hint

@ThomasEricB
Copy link
Author

Yeah, thanks for the hint

I tried to update it myself but adding the new lines causes it to stop working... I'm not sure why

@kaoneko
Copy link

kaoneko commented Dec 29, 2021

This would be great! The lack of chapters in the thumbnailer's OSC has me activating and deactivating it regularly, which is a bit of a hassle...

@marzzzello
Copy link
Owner

I updated the osc and released a new version

@ThomasEricB
Copy link
Author

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants