Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename serialize macros #36

Closed
Vavius opened this issue Feb 9, 2017 · 1 comment
Closed

Rename serialize macros #36

Vavius opened this issue Feb 9, 2017 · 1 comment

Comments

@Vavius
Copy link
Contributor

Vavius commented Feb 9, 2017

Macros from yojimbo_serialize.h look like functions in namespace, but defines ignore namespaces. I get name clash because of write_int, write_float, etc (a really common names).

Maybe rename all of them to UPPERCASE with yojimbo prefix to match the style?

@gafferongames
Copy link
Contributor

This is unfortunate, but I'd rather not have them uppercase because that would be annoying to type. If it causes problems for you, I think you can rename them locally to something that doesn't conflict.

Yes, I agree this is a bit not "perfect" but it's a stylistic thing. I spend a lot of time writing serialization functions, so I want it to be nice. Sometimes nice means, they are a little short and could conflict with other stuff. Sorry.

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants