QQ头像链接加密 #148
Merged
QQ头像链接加密 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spirit1431007
force-pushed
the
pr-branch
branch
from
e933b37
to
f2a96c3
Compare
mashirozx
reviewed
Dec 5, 2019
functions.php
Outdated
| if ( !$wpdb->get_var("SELECT COUNT(*) FROM $sakura_table_name WHERE mate_key = 'pubkey'") ){ | ||
| $pubkey = array( | ||
| "mate_key" => "pubkey", | ||
| "mate_value" => file_get_contents(get_template_directory()."/manifest/public.key") |
There was a problem hiding this comment.
public.key 放到其他文件夹吧，这个文件夹只是拿来搞缩略图的
manifest/manifest.py
Outdated
| return self.mani | ||
|
|
||
|
|
||
| class Upload2Wordpress: |
manifest/manifest.py
Outdated
| up_json = Single(f, Manifest) | ||
| up_json.upload_manifest() | ||
|
|
||
| def gen_key_pairs(): |
There was a problem hiding this comment.
RSA这一块放其他文件夹吧，manifest 以后考虑要作为一个 git 仓库 push 的，manifest.py 准备在GUI里面作为一个库引用的，多余的import会增加编译的量。
manifest/private.key
Outdated
| @@ -0,0 +1,15 @@ | |||
| -----BEGIN RSA PRIVATE KEY----- | |||
There was a problem hiding this comment.
或者更好的是php生成一个存数据库里面，不然公私钥不是大家都可以通过url拿到了么。。
There was a problem hiding this comment.
这是用python生成的，之后会存到数据库里。因为openssl.cnf的路径各运行环境不相同，所以放弃了用php生成。
There was a problem hiding this comment.
inc/api.php
Outdated
| }else{ | ||
| $response = new WP_REST_Response(); | ||
| $response->set_status(302); | ||
| $response->header('Location', $imgurl); |
There was a problem hiding this comment.
最好从评论输出那边动手。如果启用加密，则页面上的评论头像直接显示API的url，如果不启用加密，则直接显示https://q2.qlogo.cn 下头像的url。否则产生的请求数太多了，没必要。
There was a problem hiding this comment.
There was a problem hiding this comment.
啊，这地方我写错了，是有选项选择输出头像的方式的
There was a problem hiding this comment.
|
修改中 |
spirit1431007
force-pushed
the
pr-branch
branch
from
ece9097
to
e8e5630
Compare
Closed
mashirozx
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.