Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X-widget crash #69

Closed
A6GibKm opened this issue Oct 13, 2020 · 10 comments
Closed

X-widget crash #69

A6GibKm opened this issue Oct 13, 2020 · 10 comments

Comments

@A6GibKm
Copy link

A6GibKm commented Oct 13, 2020

When using xwidget to read email I get

Fatal error 11: Segmentation fault
Backtrace:
emacs[0x507831]
emacs[0x4253a0]
emacs[0x425d98]
emacs[0x62be31]
/lib64/libjavascriptcoregtk-4.0.so.18(+0x13bf95a)[0x7fd1ba1e495a]
/lib64/libpthread.so.0(+0x141e0)[0x7fd1b88e21e0]
/lib64/libc.so.6(+0x1625b5)[0x7fd1b6c525b5]
emacs[0x5e96e9]
/var/home/deathwish/.config/emacs/.local/cache/eln/28.0.50-x86_64-redhat-linux-gnu-d299cfd6d93a84d46b4eab5ce8de0072/xwidget-f9c86f6983804058a6bbecb811090bde-67a3940b0a98748a2d39ca31a2bfe13d.eln(F787769646765742d7765626b69742d63616c6c6261636b_xwidget_webkit_callback_0+0xd9)[0x7fd1a9c66cd9]
emacs[0x575750]
/var/home/deathwish/.config/emacs/.local/cache/eln/28.0.50-x86_64-redhat-linux-gnu-d299cfd6d93a84d46b4eab5ce8de0072/xwidget-f9c86f6983804058a6bbecb811090bde-67a3940b0a98748a2d39ca31a2bfe13d.eln(F787769646765742d6576656e742d68616e646c6572_xwidget_event_handler_0+0xee)[0x7fd1a9c66bee]
emacs[0x575750]
emacs[0x5757a5]
emacs[0x575750]
emacs[0x575d79]
emacs[0x579b38]
/usr/bin/../lib64/emacs/28.0.50/native-lisp/28.0.50-x86_64-redhat-linux-gnu-d299cfd6d93a84d46b4eab5ce8de0072/simple-5a237ebf745e70a3e39e2b91d2f7a105-30d32e2e4732134b53f3c96b7b1f1bf8.eln(F636f6d6d616e642d65786563757465_command_execute_0+0x251)[0x7fd1b18667a1]
emacs[0x575750]
emacs[0x4f5d2b]
emacs[0x572717]
emacs[0x4efe84]
emacs[0x572659]
emacs[0x4f1153]
emacs[0x63e74f]
emacs[0x4f5847]
emacs[0x42ef19]
/lib64/libc.so.6(__libc_start_main+0xf2)[0x7fd1b6b181a2]
emacs[0x43112e]
Segmentation fault (core dumped)

The function is mu4e-action-view-with-xwidget defined as

(defun mu4e-action-view-with-xwidget (msg)
  "View the body of MSG inside xwidget-webkit.
This is only available in Emacs 25+; also see the discussion of
privacy aspects in `(mu4e) Displaying rich-text messages'."
  (unless (fboundp 'xwidget-webkit-browse-url)
    (mu4e-error "No xwidget support available"))
  (xwidget-webkit-browse-url
   (concat "file://" (mu4e~write-body-to-html msg)) t))

I will try to produce a html file to reproduce this only using (xwidget-webkit-browse-url "file://somefile") during the week.
@A6GibKm
Copy link
Author

A6GibKm commented Oct 13, 2020

It was easier than I expected, I had a local copy of the html.

<head><meta charset="UTF-8"></head>
<p><strong>From</strong>: updates@fedoraproject.org</br><strong>To</strong>: user@email.com</br><strong>Date</strong>: Mon 12 Oct 2020 10:39:34 PM CEST</br><strong>Subject</strong>: [Fedora Update] [comment] toolbox-0.0.96-1.fc33</p><pre>
The following comment has been added to the toolbox-0.0.96-1.fc33 update:

bodhi - 2020-10-12 20:39:34.343089 (karma: 0)
rishi edited this update.

To reply to this comment, please visit the URL at the bottom of this mail

================================================================================
     FEDORA-2020-12c4232ccb
================================================================================
    Release: Fedora 33
     Status: testing
       Type: bugfix
   Severity: high
      Karma: 4
    Request: stable
      Notes: * Don't break GNU Readline's ctrl-p shortcut * Enable system tests
           : on Fedora 33 * Fix containers with missing `/media`
           : possibly due to a failed RPM transaction * Give access
           : to the udev database * Unbreak X11 applications with
           : GNOME 3.38 * Update default release to 31 for non-
           : Fedora hosts
  Submitter: rishi
  Submitted: 2020-10-02 13:56:36.076520
   Comments: bodhi - 2020-10-12 20:39:34.343089 (karma 0)
             rishi edited this update.
             Fixes issues with x11, no notable regressions.
             bodhi - 2020-10-07 14:20:29.828510 (karma 0)
             This update has been submitted for stable by bodhi.
             pnemade - 2020-10-07 14:20:29.375296 (karma 1)
             I can run x11 applications now. Rest usage of toolbox
             looks fine.
             cairo - 2020-10-02 22:57:21.043782 (karma 1)
             bodhi - 2020-10-02 22:20:59.046677 (karma 0)
             This update can be pushed to stable now if the
             maintainer wishes
             bodhi - 2020-10-02 22:18:06.993838 (karma 0)
             This update has been pushed to testing.
             feborges - 2020-10-02 14:34:52.612994 (karma 1)
             After commenting out `default_sysctls = ...` from
             /usr/share/containers/containers.conf I was able to
             test and verify that this update works. I was pointed
             out to
             https://github.com/containers/podman/issues/7766  I am
             able to run x11 applications again! Ctrl + P also
             works as expected. /media is present, same for udev
             database.
             bodhi - 2020-10-02 14:24:41.395885 (karma 0)
             This update's test gating status has been changed to
             'ignored'.
             bodhi - 2020-10-02 13:56:36.568529 (karma 0)
             This update's test gating status has been changed to
             'waiting'.
             bodhi - 2020-10-02 13:56:36.499889 (karma 0)
             This update's test gating status has been changed to
             'ignored'.
             bodhi - 2020-10-02 13:56:36.193084 (karma 0)
             This update has been submitted for testing by rishi.

  https://bodhi.fedoraproject.org/updates/FEDORA-2020-12c4232ccb


</pre>

Save as ~/some.html

and run (xwidget-webkit-browse-url "file://~/some.html").

@fejfighter
Copy link

fejfighter commented Oct 14, 2020 •
edited

@A6GibKm This appears to be an xwidgets bug, I have confirmed it on master pulled down around 10 mins ago,

Please also report it upstream.

"xwidget-webkit-title" passes NULL to build string

As an aside, there is a discussion around x-widgets on emacs-devel.

@fejfighter
Copy link

@A6GibKm please confirm https://github.com/fejfighter/emacs/tree/x-widget-null-string fixes the mu4e case

it's based of master for now but appears to satisfy the short example from comment 2.

please CC me in the bug report (<username>@gmail.com)

@A6GibKm
Copy link
Author

A6GibKm commented Oct 14, 2020

It is indeed not a pgtk bug. Closing. I will try to make some time to fill a bug upstream.

@A6GibKm A6GibKm closed this as completed Oct 14, 2020
@A6GibKm
Copy link
Author

A6GibKm commented Oct 14, 2020

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43989 @fejfighter your mail got reddacted I think so I was no able to cc you.

@fejfighter
Copy link

@A6GibKm This is now in master and #23

@A6GibKm A6GibKm mentioned this issue Oct 16, 2020
Closed
@titaniumbones
Copy link

I am hoping this lands soon in the arch linux packages, which build form @flahtwilson's repo. I'm sorry for posting in a closed issue, but does anyone (@fejfighter?) know how often that tree is updated? Thanks!

@fejfighter
Copy link

@titaniumbones, @flatwhatson seems to update fairly regularly. we're bot waiting for Andrea Corallo to pull in master, which has been fairly regular.

Hopefully it will be soon

@A6GibKm
Copy link
Author

A6GibKm commented Oct 16, 2020

I needed the patch to test stuff so badly that I just added it to the copr build.

@flatwhatson
Copy link

Thanks for the heads-up, I've merged the xwidget fix from master into my pgtk-nativecomp branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@titaniumbones @fejfighter @A6GibKm @flatwhatson