Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mason not recognizing updated tag #2450

Closed
errantepiphany opened this issue Aug 15, 2023 · 2 comments
Closed

mason not recognizing updated tag #2450

errantepiphany opened this issue Aug 15, 2023 · 2 comments

Comments

@errantepiphany
Copy link

Hello, I don't know if this is a code bug, a misconfiguration, or perhaps should be a feature request.

If you look here on line 13:
https://github.com/mason-org/mason-registry/blob/main/packages/drools-lsp/package.yaml#L13C11-L13C37
, you can see that it references the @latest tag. However, "latest" is a moving target. For example, "latest" was updated here just recently as the results of a CI build kicked off from a recent PR merge:
https://github.com/kiegroup/drools-lsp/tags
The problem is that when I ask Mason to check for (and install) updates, it doesn't recognize that "latest" was updated. I think it might be because Mason's just looking at the name of the tag, and thinks, "I've already downloaded latest - no need to do so again", but it's not taking into consideration that the timestamp on that tag has changed and it should re-download and replace it.

Now, I can understand the argument that tags shouldn't change, however "latest" is special, and I can envision other, similar moving targets. Is there anyway to configure mason to notice the updated timestamp?

Aside, yes, I recognize that there are no numbered releases in drools_lsp yet. Just the "latest" tag at this point. Whereas the Drools LSP server does function at a basic level, it is still in its early stages. Perhaps the answer is for us to just start doing numbered releases? (Like 0.1.0, 0.1.1, etc.?) I still think being able to set it up somehow to recognize tag timestamp changes would be a useful capability.

Thank you so much! :)

@errantepiphany
Copy link
Author

errantepiphany commented Aug 15, 2023

Hmmm... Do you think it would behave similarly with updated branches as it is here with tags? Does Mason only recognize numbered release tags? (Sorry for my ignorance.)

@errantepiphany
Copy link
Author

Moved to williamboman/mason.nvim#1458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant