New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added New Translation #172
Conversation
Localization and some word tweaks (adaptation) for my language, Brazilian Portugue hope it be usefull. Note: There is a typo in 'File preferences.json' line: "showInvisibles": "Snow Invisibles" should be Show not Snow :p
@andercard0 Again, please read how, and test what you would have done before PR. Have some respect. Based on the name of your commit, which does not respond to convention, you did not install the project or run it. |
Hi, I'm sorry but what? where did i unrespected you ? Only mentioned the typo in the original language if this is what you mean. Latter commit has been deleted 'cause it wasn't being changed at all from here into Github so decided to create a new one. Could you please point me out what is missing ? |
@andercard0 I don't mean respect for myself, but respect for the repository and the work. You didn't install dependencies, you didn't test your code, yet you sent a PR. Detail:
|
@andercard0 Maybe you read old documents when you started translation work. antonreshetov has already told you how to modify it, you need to pay attention that the commit comments you submit must meet the requirements, and add a button in the settings interface so that users can choose your language. Later, I believe that the experience of adding new language support will be optimized, allowing everyone to focus on translation work itself. Let's help masscode do better together. |
ah, precisly! my apologies for the confusion tho. I'll look into it later on thanks for the inputs! sorry for any inconvenience |
@sangyuxiaowu Can you make a PR based on this? It's just that this PR looks abandoned and I plan to just close it. |
Okay, maybe later, I'm going to the gym. |
Closed because it was added in #194 |
Localization and some word tweaks (adaptation) for my language, Brazilian Portugue hope it be usefull.
I hope I did not missed anything else this time :)
Note:
There is a typo in the original language 'File preferences.json' line: "showInvisibles": "Snow Invisibles" should be Show not Snow.